Add JUnit writer for speed tests, remove hardcoded reference times #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nouiz
reviewed
Oct 7, 2016
code/test.py
Outdated
| f.write('<testsuite name="theano_speedtests" tests="{ntests}">\n' | ||
| .format(ntests=numpy.size(test_total))) | ||
|
|
||
| write_junit(speed_file, algo_executed, float64_times, label='float64') |
Member
There was a problem hiding this comment.
to make the code more clear, you can do just one "with" and pass f here instead of speed_file.
Contributor
Author
There was a problem hiding this comment.
Done in new commits, also corrected some errors that would pop up if some tests flags were set to false, it would still to access the undeclared results variables.
slefrancois
force-pushed
the
speed_report
branch
from
56a358e to
0b70fc6
Compare
slefrancois
force-pushed
the
speed_report
branch
from
0b70fc6 to
f14107d
Compare
slefrancois
force-pushed
the
speed_report
branch
from
926ba5f to
f724c2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.